Attention is currently required from: pespin, dexter.
Patch set 4:Code-Review +1
8 comments:
Patchset:
None of my comments are critical, looks nice to me in general!
File include/osmocom/gprs/llc/llc_private.h:
Patch Set #4, Line 36: OSMO_
Private API should not be using the 'OSMO_' prefix, right?
Patch Set #4, Line 52: OSMO_
Same here: drop 'OSMO_' prefix.
Patch Set #4, Line 78: OSMO_
Same here: drop 'OSMO_' prefix.
Patch Set #4, Line 116: OSMO_
Same here: drop 'OSMO_' prefix.
Patch Set #4, Line 131: OSMO_
Same here: drop 'OSMO_' prefix.
Patch Set #4, Line 154: OSMO_
Same here: drop 'OSMO_' prefix.
File src/llc/llc.c:
Patch Set #4, Line 203: &llme->lle[sapi]
We may want to check-if/assert-that: sapi < ARRAY_SIZE(llme->lle).
To view, visit change 30489. To unsubscribe, or for help writing mail filters, visit settings.