Attention is currently required from: neels, pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: vty: Add check against sensible default value for Ny1 ......................................................................
Patch Set 20:
(3 comments)
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/504ffeb6_ab013f43 PS18, Line 1724: bool gsm_bts_check_ny1(struct gsm_bts *bts, unsigned int log_level)
btw, I didn't notice before, but bts can probably be a const pointer here?
Done
File src/osmo-bsc/bts.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/4b147746_65070da8 PS19, Line 1734: "Is: %lu Lowest recommendation: %lu\n",
"Is: %lu, Lowest recommendation: %lu\n" (see extra comma)
Done
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/778a24e4_c0742cb4 PS18, Line 95: gsm_bts_check_ny1(bts, LOGL_NOTICE);
We have plenty of error messages which doesn't exit the process. […]
Done
-
arehbein