Attention is currently required from: neels, pespin, fixeria.

View Change

3 comments:

• File src/osmo-bsc/bts.c:

  • Patch Set #18, Line 1724: bool gsm_bts_check_ny1(struct gsm_bts *bts, unsigned int log_level)

    btw, I didn't notice before, but bts can probably be a const pointer here?

    Done

• File src/osmo-bsc/bts.c:

  • Patch Set #19, Line 1734: "Is: %lu Lowest recommendation: %lu\n",

    "Is: %lu, Lowest recommendation: %lu\n" (see extra comma)

    Done

• File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

  • Patch Set #18, Line 95: gsm_bts_check_ny1(bts, LOGL_NOTICE);

    We have plenty of error messages which doesn't exit the process. […]

    Done

To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.