Attention is currently required from: jolly.
pespin has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/libosmocore/+/40490?usp=email )
Change subject: Submit all SQEs to kernel if they don't fit in the io_uring
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40490/comment/88a3ad63_028b3dfa?… :
PS3, Line 139: sqe = io_uring_get_sqe(&g_ring.ring);
I bet this can still probably return NULL since between call to io_uring_submit() and this
line the kernel may not have had time to process any sqe in the queue.
hence probably the OSMO_ASSERT(sqe) below will potentially be false at some point.
Feel free to tell me I'm wrong, I'm just assuming the behavior/API here.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/40490?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I476d9db285a1d257a4a5d43ee45ee0116c7d7009
Gerrit-Change-Number: 40490
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 04 Jul 2025 13:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes