Attention is currently required from: jolly.

Patch set 3:Code-Review -1

View Change

1 comment:

• File src/core/osmo_io_uring.c:

  • Patch Set #3, Line 139: sqe = io_uring_get_sqe(&g_ring.ring);

    I bet this can still probably return NULL since between call to io_uring_submit() and this line the kernel may not have had time to process any sqe in the queue.
    hence probably the OSMO_ASSERT(sqe) below will potentially be false at some point.

    Feel free to tell me I'm wrong, I'm just assuming the behavior/API here.

To view, visit change 40490. To unsubscribe, or for help writing mail filters, visit settings.