Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email )
Change subject: Do not reconnect when receiving SCTP notification ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File src/stream_cli.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36568/comment/7b0deb09_8508b6ce PS1, Line 500: if (res == -EAGAIN) {
Wait, that's wrong though, you are basically preventing stream_cli users to get SCTP notifications, […]
You should be handling case "if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION)" inside stream_cli_handle_connecting() imho, based on event you'll want to reconnect(). At least handle it inside switch case here in line 507.
-
pespin