Attention is currently required from: jolly.

Patch set 1:Code-Review -2

View Change

1 comment:

• File src/stream_cli.c:

  • Patch Set #1, Line 500: if (res == -EAGAIN) {

    Wait, that's wrong though, you are basically preventing stream_cli users to get SCTP notifications, […]

    You should be handling case "if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION)" inside stream_cli_handle_connecting() imho, based on event you'll want to reconnect().
    At least handle it inside switch case here in line 507.

To view, visit change 36568. To unsubscribe, or for help writing mail filters, visit settings.