Attention is currently required from: fixeria, pespin.

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42141?usp=email )

Change subject: twjit: add underrun extension feature ......................................................................

Patch Set 2:

(2 comments)

File src/twjit.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/1019d477_d2aed98e... : PS1, Line 554: twjit->stats.underruns++;

shouldn't "twjit->stats. […]

In the new iteration of my patch, I added a comment explaining while this stats counter should not be incremented in this state.

https://gerrit.osmocom.org/c/libosmo-netif/+/42141/comment/fc7dc15b_d96620fd... : PS1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)

Some ideas, no need to apply them if you don't want: […]

I added an explanatory comment in the new iteration of my patch - is it good enough?