Attention is currently required from: fixeria, pespin.

View Change

2 comments:

• File src/twjit.c:

  • Patch Set #1, Line 554: twjit->stats.underruns++;

    shouldn't "twjit->stats. […]

    In the new iteration of my patch, I added a comment explaining while this stats counter should not be incremented in this state.

  • Patch Set #1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)

    Some ideas, no need to apply them if you don't want: […]

    I added an explanatory comment in the new iteration of my patch - is it good enough?

To view, visit change 42141. To unsubscribe, or for help writing mail filters, visit settings.