Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-s1gw/+/37054?usp=email )
Change subject: Makefile,contrib/jenkins: import from osmo-epdg ......................................................................
Patch Set 2:
(4 comments)
File Makefile:
https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/c362a459_cea0eaa5 PS1, Line 9: epdg
Ack
Done
https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/4dc389e7_6e5ae7be PS1, Line 25: rm -f src/diameter_*.erl
Ack
Done
File Makefile:
https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/64cf4bc3_06eee0aa PS2, Line 5: src/S1AP-%.erl include/S1AP-%.hrl: asn1/S1AP-%.asn FYI: The idea here is to avoid re-compiling ASN.1 files every time we do `build`, `run`, or `shell`. make will invoke `rebar3 asn compile` only if it's necessary.
https://gerrit.osmocom.org/c/osmo-s1gw/+/37054/comment/09279184_50029bb2 PS2, Line 18: check: $(GEN_FILES) FYI: `rebar3 eunit` should not depend on `build` because it compiles all `*.erl` files independently (with different flags) and puts the resulting `*.beam` files to `_build/test/` (not `_build/default/`).
-
fixeria