Attention is currently required from: laforge, osmith, pespin.

View Change

4 comments:

• File Makefile:

  • Patch Set #1, Line 9: epdg

    Ack

    Done

  • Patch Set #1, Line 25: rm -f src/diameter_*.erl

    Ack

    Done

• File Makefile:

  • Patch Set #2, Line 5: src/S1AP-%.erl include/S1AP-%.hrl: asn1/S1AP-%.asn

    FYI: The idea here is to avoid re-compiling ASN.1 files every time we do `build`, `run`, or `shell`. make will invoke `rebar3 asn compile` only if it's necessary.

  • Patch Set #2, Line 18: check: $(GEN_FILES)

    FYI: `rebar3 eunit` should not depend on `build` because it compiles all `*.erl` files independently (with different flags) and puts the resulting `*.beam` files to `_build/test/` (not `_build/default/`).

To view, visit change 37054. To unsubscribe, or for help writing mail filters, visit settings.