[XL] Change in osmo-hnbgw[master]: per-HNB GTP-U traffic counters via nft - gerrit-log

21 May 2024

Attention is currently required from: neels, pespin.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )

Change subject: per-HNB GTP-U traffic counters via nft
......................................................................

Patch Set 6:

(6 comments)

File include/osmocom/hnbgw/hnbgw.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/f24a208b_f76c6399 
PS6, Line 394: 		struct osmo_sockaddr_str addr_remote;
...
  open question: to be seen whether it makes more sense
to use a osmo_sockaddr instead here. […] libnftables interfacing is string based, as
the patch should show in other places

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/97e043bd_58c8421e 
PS6, Line 446: 			bool enable;
...
  some short comment here on what these do would be
welcome. I actually think they are self-explanatory.

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/0cc2af5c_e83598e1 
PS6, Line 483: 	struct {
...
  same here, some comment welcome. I actually
think they are self-explanatory.

File include/osmocom/hnbgw/nft_kpi.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/34cfe65b_bb6094e9 
PS6, Line 7: struct nft_kpi_handle {
...
  Some comments docummenting these structs and fields
may be welcome. I actually think they are simple, clarly named and
self-explanatory.

File src/osmo-hnbgw/nft_kpi.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/30e6cd61_14520ed5 
PS6, Line 35: {
...
  I guess these will be filled up by follow-up patches
adding hashtables? those are the stubs for when you are compiling osmo-hnbgw without
libnftables support

https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/9becf34f_bf329996 
PS6, Line 86: static __thread struct nft_thread *g_nft_thread = NULL;
...
  Simply have one var per thread, even better when you
split stuff into different files. 
isn't that what __thread is for?

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca
Gerrit-Change-Number: 36539
Gerrit-PatchSet: 6
Gerrit-Owner: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 21 May 2024 20:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment