Attention is currently required from: neels, pespin.
6 comments:
File include/osmocom/hnbgw/hnbgw.h:
Patch Set #6, Line 394: struct osmo_sockaddr_str addr_remote;
open question: to be seen whether it makes more sense to use a osmo_sockaddr instead here. […]
libnftables interfacing is string based, as the patch should show in other places
Patch Set #6, Line 446: bool enable;
some short comment here on what these do would be welcome.
I actually think they are self-explanatory.
Patch Set #6, Line 483: struct {
same here, some comment welcome.
I actually think they are self-explanatory.
File include/osmocom/hnbgw/nft_kpi.h:
Patch Set #6, Line 7: struct nft_kpi_handle {
Some comments docummenting these structs and fields may be welcome.
I actually think they are simple, clarly named and self-explanatory.
File src/osmo-hnbgw/nft_kpi.c:
I guess these will be filled up by follow-up patches adding hashtables?
those are the stubs for when you are compiling osmo-hnbgw without libnftables support
Patch Set #6, Line 86: static __thread struct nft_thread *g_nft_thread = NULL;
Simply have one var per thread, even better when you split stuff into different files.
isn't that what __thread is for?
To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.