[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA - gerrit-log

15 Jul 2025

Attention is currently required from: fixeria, lynxis lazus.

pespin has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email )

Change subject: routing area: introduce ran_type on the RA
......................................................................

Patch Set 2:

(4 comments)

File include/osmocom/sgsn/gprs_routing_area.h:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/7a12eec4_e67b97e6?us… :
PS2, Line 34: 	 * and for routing, the SGSN must know to which PCU a given cell is
connected.
"... and, for routing, the SGSN".
Or even better, remove the "and" and add a dot ;)

https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/8bed0963_826b0559?us… :
PS2, Line 35: 2x PCU serves
...
  you mean "more than one PCU" here?
Agree with fixeria, writing like does clarifies it.

https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/707827e3_cd56f902?us… :
PS2, Line 47: which are alive
...
  maybe call it `alive_cells` or `cells_alive` then?
yeah, known_cells, active_cells, served_cells, whatever. And Usually having
"_list" suffix also helps imho.

File src/sgsn/gprs_routing_area.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/9738e2c3_3b1daaa5?us… :
PS2, Line 201: valid for GERAN
...
  If some API is GERAN specific, maybe function names
should reflect that? […] I agree, but this commit can't fix all that at the same
time.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c
Gerrit-Change-Number: 40688
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: lynxis lazus &lt;lynxis(a)fe80.eu&gt;
Gerrit-Comment-Date: Tue, 15 Jul 2025 20:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;