Attention is currently required from: fixeria, lynxis lazus.
4 comments:
File include/osmocom/sgsn/gprs_routing_area.h:
Patch Set #2, Line 34: * and for routing, the SGSN must know to which PCU a given cell is connected.
"... and, for routing, the SGSN".
Or even better, remove the "and" and add a dot ;)
Patch Set #2, Line 35: 2x PCU serves
you mean "more than one PCU" here?
Agree with fixeria, writing like does clarifies it.
Patch Set #2, Line 47: which are alive
maybe call it `alive_cells` or `cells_alive` then?
yeah, known_cells, active_cells, served_cells, whatever. And Usually having "_list" suffix also helps imho.
File src/sgsn/gprs_routing_area.c:
Patch Set #2, Line 201: valid for GERAN
If some API is GERAN specific, maybe function names should reflect that? […]
I agree, but this commit can't fix all that at the same time.
To view, visit change 40688. To unsubscribe, or for help writing mail filters, visit settings.