Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37839?usp=email ) Change subject: pySim-shell: prevent opening/closing logical channel 0 ...................................................................... Patch Set 5: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37839/comment/a885ec85_7a068070?usp=em… : PS4, Line 968: choices=range(1,4), Yes, range(1,4) excludes the 4 (i find that a bit confusing, bit it seems to be some half open interval thing...) I noticed that only lchan 1-3 were working properly, so my impression was that we would only support the standard logical channel numbers. However, when I look at the code I get the impression that in some cases the extended logical channels are supported as well. I think it is probably better to allow standard and extended lchan numbers in the command arguments. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4eebd9f15fadd18e1caeb033fda36c59446fcab8 Gerrit-Change-Number: 37839 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Aug 2024 10:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>