Attention is currently required from: fixeria, laforge.

View Change

1 comment:

• File pySim-shell.py:

  • Patch Set #4, Line 968: choices=range(1,4),

    (just to be sure) the new value range is `[1, 2, 3]` (excluding `4`), correct? […]

    Yes, range(1,4) excludes the 4 (i find that a bit confusing, bit it seems to be some half open interval thing...)

    I noticed that only lchan 1-3 were working properly, so my impression was that we would only support the standard logical channel numbers. However, when I look at the code I get the impression that in some cases the extended logical channels are supported as well. I think it is probably better to allow standard and extended lchan numbers in the command arguments.

To view, visit change 37839. To unsubscribe, or for help writing mail filters, visit settings.