Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37839?usp=email )
Change subject: pySim-shell: prevent opening/closing logical channel 0 ......................................................................
Patch Set 5:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37839/comment/a885ec85_7a068070?usp=ema... : PS4, Line 968: choices=range(1,4),
(just to be sure) the new value range is `[1, 2, 3]` (excluding `4`), correct? […]
Yes, range(1,4) excludes the 4 (i find that a bit confusing, bit it seems to be some half open interval thing...)
I noticed that only lchan 1-3 were working properly, so my impression was that we would only support the standard logical channel numbers. However, when I look at the code I get the impression that in some cases the extended logical channels are supported as well. I think it is probably better to allow standard and extended lchan numbers in the command arguments.