Attention is currently required from: jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email )

Change subject: ASCI: Add GCC/BCC (call control) to mobility management ......................................................................

Patch Set 3:

(3 comments)

File src/host/layer23/src/mobile/gsm48_mm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/2f157f65_9ab36e21 PS3, Line 789: case GSM48_MMGCC_CLASS: Maybe some explanation why is this added here ad does nothing?

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/7fd209d7_6af18d9d PS3, Line 4096: mm_conn_new_ref++); wrong indentation. You can actually put it in the same line.

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/3ef173dd_0f012d4a PS3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { wrong indentation.

I personally prefer:

if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) { while some other people prefer:

if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {