Attention is currently required from: jolly.

View Change

3 comments:

• File src/host/layer23/src/mobile/gsm48_mm.c:

  • Patch Set #3, Line 789: case GSM48_MMGCC_CLASS:

    Maybe some explanation why is this added here ad does nothing?

  • Patch Set #3, Line 4096: mm_conn_new_ref++);

    wrong indentation. You can actually put it in the same line.

  • Patch Set #3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {

    wrong indentation.

    I personally prefer:

    	if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD ||
    	    mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {
    	   
    while some other people prefer:

    	if (mm->state == GSM48_MM_ST_WAIT_NETWORK_CMD
    	    || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {

To view, visit change 34476. To unsubscribe, or for help writing mail filters, visit settings.