Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email ) Change subject: After writing VTY config, run sync() in a different thread ...................................................................... Patch Set 2: (2 comments) File src/vty/command.c: https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/12468d57_8711ac6a?… : PS2, Line 3413: sync(); : sync_complete(&sync_fd, 0); : common path for all failing checks, maybe move it down below to the bottom and use `goto`? https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/9035dec6_77e28dbe?… : PS2, Line 3439: LOGP(DLGLOBAL, LOGL_ERROR, "Failed to create thread, syncing without thread.\n"); missing `osmo_fd_unregister()` here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3cb2ee68b2e4c730f96522208c4abf00d0f49a44 Gerrit-Change-Number: 37798 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 12 Aug 2024 16:33:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No