Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread ......................................................................
Patch Set 2:
(2 comments)
File src/vty/command.c:
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/12468d57_8711ac6a?u... : PS2, Line 3413: sync(); : sync_complete(&sync_fd, 0); : common path for all failing checks, maybe move it down below to the bottom and use `goto`?
https://gerrit.osmocom.org/c/libosmocore/+/37798/comment/9035dec6_77e28dbe?u... : PS2, Line 3439: LOGP(DLGLOBAL, LOGL_ERROR, "Failed to create thread, syncing without thread.\n"); missing `osmo_fd_unregister()` here?