Attention is currently required from: jolly.

View Change

2 comments:

• File src/vty/command.c:

  • Patch Set #2, Line 3413:

    		sync();
    		sync_complete(&sync_fd, 0);
    		
    

    common path for all failing checks, maybe move it down below to the bottom and use `goto`?

  • Patch Set #2, Line 3439: LOGP(DLGLOBAL, LOGL_ERROR, "Failed to create thread, syncing without thread.\n");

    missing `osmo_fd_unregister()` here?

To view, visit change 37798. To unsubscribe, or for help writing mail filters, visit settings.