Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33690 ) Change subject: pySim/cards: Split legacy classes away from core SIM + UICC ...................................................................... Patch Set 4: Code-Review-1 (3 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/33690/comment/daa21400_e2006d2a PS4, Line 31: base class Do we want to make it an abstract base class (`(a)abc.ABC`)? https://gerrit.osmocom.org/c/pysim/+/33690/comment/f2757feb_e0555905 PS4, Line 41: self._aids = [] unreachable code https://gerrit.osmocom.org/c/pysim/+/33690/comment/9b50a616_fc80f1be PS4, Line 319: SimCard `UiccCardBase` is a [grand]child of `SimCard`, do we really need `SimCard` here? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id36140675def5fc44eedce81fc7b09e0adc527e1 Gerrit-Change-Number: 33690 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 16:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment