Attention is currently required from: laforge, dexter.

Patch set 4:Code-Review -1

View Change

3 comments:

• File pySim/cards.py:

  • Patch Set #4, Line 31: base class

    Do we want to make it an abstract base class (`@abc.ABC`)?

  • Patch Set #4, Line 41: self._aids = []

    unreachable code

  • Patch Set #4, Line 319: SimCard

    `UiccCardBase` is a [grand]child of `SimCard`, do we really need `SimCard` here?

To view, visit change 33690. To unsubscribe, or for help writing mail filters, visit settings.