Attention is currently required from: fixeria.
char has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36376?usp=email )
Change subject: add missing modules to setup.py
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Thanks, the fix looks good. […]
Calling each
binary with `--help` during build and checking if it crashes is a fairly simple
"smoke test" I've seen done before. That would have caught the issue fixed
by this patch, at least.
If you'd like me to do that, I'll add it in a separate patch set.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom(a)hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 17:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: char <osmocom(a)hypodyne.net>
Gerrit-MessageType: comment