Attention is currently required from: fixeria.
View Change
1 comment:
Patchset:
Patch Set #2:
Thanks, the fix looks good. […]
Calling each binary with `--help` during build and checking if it crashes is a fairly simple "smoke test" I've seen done before. That would have caught the issue fixed by this patch, at least.
If you'd like me to do that, I'll add it in a separate patch set.
To view, visit change 36376. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom@hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Mar 2024 17:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: char <osmocom@hypodyne.net>
Gerrit-MessageType: comment