Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 13: (11 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/0afef1a4_4711cd49 PS13, Line 10: BTS BSC ? https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/10175f21_0d64f14e PS13, Line 15: fun fun?? =) Patchset: PS13: sorry that my comments are very meta, because i don't really understand the context... File src/ericsson-rbs/er_ccu_if.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/ab9a5fed_2d0bf0d7 PS13, Line 62: /* called by trau frame synchronizer: feed received MAC blocks into PCU */ does it make sense to document who calls the function? usually we just describe what it does? https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/1b8aeb76_e8ad92c1 PS13, Line 76: multeiplexer multiplexer https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/a3bcc7db_b70062a1 PS13, Line 90: multeiplexer i https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/72f705bd_87fca6dc PS13, Line 99: Function to (drop the first two words) https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/c9dcc83a_f8d709ec PS13, Line 122: , (nicer to start a new line for osmo_hexdump) https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/208d920e_7887116f PS13, Line 143: (line=%u,ts=%u) seems this log context occurs in several places, welcome a LOG_FOO() macro instead of code dup. Isn't LOG_CCU() exactly that? https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/500a66a4_2534f826 PS13, Line 146: Note "Note"? =) https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/d1f19651_4c9ced07 PS13, Line 184: /* NOTE: This is a serious error: subslots should be removed when l1if_close_pdch() is called by the PCU. This (seems this comment wants to be inside the if { .. } body.) (also you seem to write "note" a lot =) but '/*' already says "note" implicitly ) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Feb 2023 01:17:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment