Attention is currently required from: dexter.

View Change

11 comments:

• Commit Message:

  • Patch Set #13, Line 10: BTS

    BSC ?

  • Patch Set #13, Line 15: fun

    fun?? =)

• Patchset:

  • Patch Set #13:

    sorry that my comments are very meta, because i don't really understand the context...

• File src/ericsson-rbs/er_ccu_if.c:

  • Patch Set #13, Line 62: /* called by trau frame synchronizer: feed received MAC blocks into PCU */

    does it make sense to document who calls the function? usually we just describe what it does?

  • Patch Set #13, Line 76: multeiplexer

    multiplexer

  • Patch Set #13, Line 90: multeiplexer

    i

  • Patch Set #13, Line 99: Function to

    (drop the first two words)

  • Patch Set #13, Line 122: ,

    (nicer to start a new line for osmo_hexdump)

  • Patch Set #13, Line 143: (line=%u,ts=%u)

    seems this log context occurs in several places, welcome a LOG_FOO() macro instead of code dup. Isn't LOG_CCU() exactly that?

  • Patch Set #13, Line 146: Note

    "Note"? =)

  • Patch Set #13, Line 184: /* NOTE: This is a serious error: subslots should be removed when l1if_close_pdch() is called by the PCU. This

    (seems this comment wants to be inside the if { .. } body.)

    (also you seem to write "note" a lot =) but '/*' already says "note" implicitly )

To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.