Attention is currently required from: arehbein, daniel, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email )

Change subject: osmo_io: Remove union in struct osmo_io_ops ......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4: It can know based on the OSMO_IO_FD_MODE configured during osmo_iofd_setup(). So before using one callback, the implementation needs to check ofc also the io mode is the one used. It doesn't make sense for a user of the API to set one io_mode and then set callbacks for the other mode, this is a bug in the user, wrong use of the API.

it's possible to create an osmo_io_fd using osmo_iofd_setup in one mode (e.g. OSMO_IO_FD_MODE_READ_WRITE) but the register an osmo_io_ops with wrong call-backs (e.g. recvfrom/sendto).

IMHO that's a bug / wrong use of the API at the user and nothing to be fixed in the osmo_io implementation.