Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31111 )

Change subject: pcu_sock: inform when no PDCH is available at all ......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/31111/comment/f2cd7d02_f78c0761 PS1, Line 7: pcu_sock: complain when not PDCH is available at all

"no PDCH"

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/31111/comment/34d9ac8e_1a30795d PS1, Line 9: In case no PDCH is currently available (resources exhausted, or simple a

"simply"

Done

Patchset:

PS1:

Agreeing with Pau here.

I do not entirely agree. A non-pdch/non-gprs network won't print the message anyway since the code path is only executed when a PCU is connected.

At least from what I can say the information helped me to identify problems during development but I do not insist on merging this. Once everything works we can drop the patch as well. But I still think the info is helpful.

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31111/comment/9fb05f3a_bc7c6d4f PS1, Line 165: found_pdch

no need for an additional variable, simply check if: trx_info->pdch_mask == 0.

Done