Attention is currently required from: fixeria, pespin.

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: pcu_sock: complain when not PDCH is available at all

    "no PDCH"

    Done

  • Patch Set #1, Line 9: In case no PDCH is currently available (resources exhausted, or simple a

    "simply"

    Done

• Patchset:

  • Patch Set #1:

    Agreeing with Pau here.

    I do not entirely agree. A non-pdch/non-gprs network won't print the message anyway since the code path is only executed when a PCU is connected.

    At least from what I can say the information helped me to identify problems during development but I do not insist on merging this. Once everything works we can drop the patch as well. But I still think the info is helpful.

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #1, Line 165: found_pdch

    no need for an additional variable, simply check if: trx_info->pdch_mask == 0.

    Done

To view, visit change 31111. To unsubscribe, or for help writing mail filters, visit settings.