Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email ) Change subject: Add unit tests for S1 HANDOVER procedure ...................................................................... Patch Set 1: (5 comments) File test/s1ap_proxy_test.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/f463dd18_24e9… : PS1, Line 380: unrelated ws removal https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a4c1c2cc_e157… : PS1, Line 76: peperation prep{E->A}ration https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/968a0c48_3045… : PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)), : Here we expect the PDUs to be forwarded as-is (unmodified), right? We should not be matching anything here (`_`), but the same binary blobs: ``` ?_assertEqual({forward, HandoverRqd}, ... ?_assertEqual({forward, HandoverCmd}, ... ``` https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/de23fb6d_3882… : PS1, Line 413: HANDOVER REQUEST This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/d135e0aa_2825… : PS1, Line 416: MME -> eNB ... and the opposite direction here: `[eNB -> MME]`. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0 Gerrit-Change-Number: 41029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Comment-Date: Thu, 04 Sep 2025 11:10:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No