Attention is currently required from: jolly.

View Change

5 comments:

• File test/s1ap_proxy_test.erl:

  • Patch Set #1, Line 380:

    unrelated ws removal

  • Patch Set #1, Line 76: peperation

    prep{E->A}ration

  • Patch Set #1, Line 403:

        [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)),
      
    

    Here we expect the PDUs to be forwarded as-is (unmodified), right?
    We should not be matching anything here (`_`), but the same binary blobs:

    ```
    ?_assertEqual({forward, HandoverRqd}, ...
    ?_assertEqual({forward, HandoverCmd}, ...
    ```

  • Patch Set #1, Line 413: HANDOVER REQUEST

    This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`.

  • Patch Set #1, Line 416: MME -> eNB

    ... and the opposite direction here: `[eNB -> MME]`.

To view, visit change 41029. To unsubscribe, or for help writing mail filters, visit settings.