Attention is currently required from: iedemam, neels, laforge, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 )
Change subject: Expand VTY option which controls use of TCH for signalling
......................................................................
Patch Set 5: Code-Review-1
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/f34745a7_1e9413ef
PS5, Line 568: chan_alloc_allow
Why are you removing this part?
It's still a channel allocator specific option, right?
https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/84e3e321_db602deb
PS5, Line 582: !strcmp(argv[0], "0")
argv[0] can not be "0" or "1" anymore (because you've changed the command vector from '0|1' to 'never|voice|always'). You should add an alias for backwards-compatibility, `grep ALIAS_DEPRECATED` for examples.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28276
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640
Gerrit-Change-Number: 28276
Gerrit-PatchSet: 5
Gerrit-Owner: iedemam
michael@kapsulate.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: iedemam
michael@kapsulate.com
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 15 Jun 2022 09:14:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria