Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30566 ) Change subject: Move first_common_ts from gprs_rlcmac_tbf to GprsMs ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File src/gprs_ms.h: https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/b1647104_20d85087 PS2, Line 67: simultaniously Done File src/pcu_vty_functions.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/70152e90_b2b96b58 PS2, Line 64: PRId8 I am not saying it's wrong, I was wondering why it's really needed here. I see you're not only moving a field from one struct to another, but also changing it from unsigned to signed. And %d we already have here would still work fine for signed. In any case, not a merge blocker. File src/pcu_vty_functions.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/df343a7a_140af90a PS3, Line 57: struct GprsMs *ms const -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30566 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8df01a99ccbfaf7a442ade5000ee282bd638fbba Gerrit-Change-Number: 30566 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 21:06:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment