Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30566 )

Change subject: Move first_common_ts from gprs_rlcmac_tbf to GprsMs ......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File src/gprs_ms.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/b1647104_20d85087 PS2, Line 67: simultaniously

Yes, I simply moved the comment. I can change the description as you suggest though.

Done

File src/pcu_vty_functions.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/70152e90_b2b96b58 PS2, Line 64: PRId8

what's wrong with using the proper type for the variable? […]

I am not saying it's wrong, I was wondering why it's really needed here. I see you're not only moving a field from one struct to another, but also changing it from unsigned to signed. And %d we already have here would still work fine for signed. In any case, not a merge blocker.

File src/pcu_vty_functions.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/30566/comment/df343a7a_140af90a PS3, Line 57: struct GprsMs *ms const