Attention is currently required from: laforge, pespin.

Patch set 3:Code-Review +1

View Change

3 comments:

• File src/gprs_ms.h:

  • Patch Set #2, Line 67: simultaniously

    Yes, I simply moved the comment. I can change the description as you suggest though.

    Done

• File src/pcu_vty_functions.cpp:

  • Patch Set #2, Line 64: PRId8

    what's wrong with using the proper type for the variable? […]

    I am not saying it's wrong, I was wondering why it's really needed here. I see you're not only moving a field from one struct to another, but also changing it from unsigned to signed. And %d we already have here would still work fine for signed. In any case, not a merge blocker.

• File src/pcu_vty_functions.cpp:

  • Patch Set #3, Line 57: struct GprsMs *ms

    const

To view, visit change 30566. To unsubscribe, or for help writing mail filters, visit settings.