Attention is currently required from: falconia, fixeria.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36967?usp=email )

Change subject: gsm48_ie: add helper function for speech bearer cap on GSM MS side ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/36967/comment/dc9b1d48_d8463cb9 PS1, Line 9: The speech version list part of TS 24.008 section 10.5.4.5 bearer I think it would be great if this explanation is in the api doc comment for the function, because it helps to understand a great deal, and in a commit log it is far less visible than in the api doc...

If it was me, I'd start it like

``` /*! Fill out full gsm_mncc_bearer_cap from speech version list and CTM flag. * * This function is meant to be called only [...]. * * The speech version list part of TS 24.008 [...] * [...] only v1 codecs are supported. */ int gsm48_ms_prepare_speech_bearer_cap(struct gsm_mncc_bearer_cap *bcap) { ```

Patchset:

PS1: I'm a bit unsure, would be great to know if @vyanitskiy@sysmocom.de is good with this?