Attention is currently required from: falconia, fixeria.

Patch set 1:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 9: The speech version list part of TS 24.008 section 10.5.4.5 bearer

    I think it would be great if this explanation is in the api doc comment for the function, because it helps to understand a great deal, and in a commit log it is far less visible than in the api doc...

    If it was me, I'd start it like

    ```
    /*! Fill out full gsm_mncc_bearer_cap from speech version list and CTM flag.
     *
     * This function is meant to be called only [...].
     *
     * The speech version list part of TS 24.008 [...]
     * [...] only v1 codecs are supported.
     */
    int gsm48_ms_prepare_speech_bearer_cap(struct gsm_mncc_bearer_cap *bcap)
    {
    ```

• Patchset:

  • Patch Set #1:

    I'm a bit unsure, would be great to know if @vyanitskiy@sysmocom.de is good with this?

To view, visit change 36967. To unsubscribe, or for help writing mail filters, visit settings.