Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 )
Change subject: trxcon: make l1sched logging configurable, use trxcon->fi as prefix ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
File src/host/trxcon/src/sched_trx.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/23078a92_c0deb6e9 PS3, Line 167: .cfg = *cfg, This is probably wrong now. You are copying a pointer to a string here, which means somehow the caller needs to keep the pointer alive during l1sched_state lifespan... You probably want to talloc_strdup it.
File src/host/trxcon/src/trxcon.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/ed583004_1412ffe5 PS3, Line 362: return trxcon; leak of trxon->log_prefix here.