Attention is currently required from: laforge, fixeria.

Patch set 3:Code-Review -1

View Change

2 comments:

• File src/host/trxcon/src/sched_trx.c:

  • Patch Set #3, Line 167: .cfg = *cfg,

    This is probably wrong now. You are copying a pointer to a string here, which means somehow the caller needs to keep the pointer alive during l1sched_state lifespan...
    You probably want to talloc_strdup it.

• File src/host/trxcon/src/trxcon.c:

  • Patch Set #3, Line 362: return trxcon;

    leak of trxon->log_prefix here.

To view, visit change 28744. To unsubscribe, or for help writing mail filters, visit settings.