Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )
Change subject: add library/PFCP_*, deps/PFCP ......................................................................
Patch Set 3:
(2 comments)
File library/PFCP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/377dd1d4_ffb79... PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {
the thing that annoys me there is that universal-ctags in general does a good job of taging ttcn3, b […]
I'm sorry but your personal tooling is not an acceptable motivation to avoid specifying template types properly, which affects everybody else.
It shows a lot of errors and also makes stuff more difficult when using them due to constrictions. Think of it as if it was a const pointer mark, or a nullable pointer mark.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/25670c34_8ea44... PS1, Line 460: function tr_PFCP_Session_Est_Resp(template OCT8 hdr_seid := ?) return template PDU_PFCP {
why?
Can it be "omit"? then "template (omit)", otherwise "template (present)". You see, they serve to actually provide information on what can be passed to it.
-
pespin