Attention is currently required from: iedemam, neels, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28276 ) Change subject: Expand VTY option which controls use of TCH for signalling ...................................................................... Patch Set 5: (3 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/d595fb3a_7c21e1d8 PS5, Line 263: BTS_TCH_SIGNALLING_NEVER, Maybe NEVER->NONE and ALWAYS->ALL would be more meanginful, but not really sure about it, so letting you decide here. File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/07dfc2cc_922ff066 PS5, Line 2177: /* else: Emergency calls will be put on a free TCH/H or TCH/F directly We should probably discuss this. If you currently select BTS_TCH_SIGNALLING_NEVER in your patch, you would be skipping the path to assign a TCH directly for an emergency call, which is probably something you want to do even if you chose BTS_TCH_SIGNALLING_NEVER. It may make more sense to rename it to BTS_TCH_SIGNALLING_EMERGENCY_CALL. If you still want to really have a NEVER option for whatever reason, then better add an EMERGENCY_CALL one too? https://gerrit.osmocom.org/c/osmo-bsc/+/28276/comment/70c35a95_1bb163cb PS5, Line 2181: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS If you don't mind, this would be probably more readable, since the same check is done first: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS || (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_VOICE && gsm_chreq_reason_is_voicecall(rqd->reason))) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4459941ddad4e4a3bec8409b180d9a23a735e640 Gerrit-Change-Number: 28276 Gerrit-PatchSet: 5 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jun 2022 10:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment