Attention is currently required from: iedemam, neels, laforge, dexter.

View Change

3 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #5, Line 263: BTS_TCH_SIGNALLING_NEVER,

    Maybe NEVER->NONE and ALWAYS->ALL would be more meanginful, but not really sure about it, so letting you decide here.

• File src/osmo-bsc/abis_rsl.c:

  • Patch Set #5, Line 2177: /* else: Emergency calls will be put on a free TCH/H or TCH/F directly

    We should probably discuss this. If you currently select BTS_TCH_SIGNALLING_NEVER in your patch, you would be skipping the path to assign a TCH directly for an emergency call, which is probably something you want to do even if you chose BTS_TCH_SIGNALLING_NEVER.
    It may make more sense to rename it to BTS_TCH_SIGNALLING_EMERGENCY_CALL.
    If you still want to really have a NEVER option for whatever reason, then better add an EMERGENCY_CALL one too?

  • Patch Set #5, Line 2181: if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS

    If you don't mind, this would be probably more readable, since the same check is done first:
     if (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_ALWAYS ||
         (bts->tch_for_signalling_policy == BTS_TCH_SIGNALLING_VOICE &&
          gsm_chreq_reason_is_voicecall(rqd->reason)))

To view, visit change 28276. To unsubscribe, or for help writing mail filters, visit settings.