Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30465 ) Change subject: clarify comments and naming around PDR+FAR classification ...................................................................... Patch Set 1: (3 comments) File include/osmocom/upf/up_session.h: https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/6c3f64b1_d09f85f6 PS1, Line 97: bool access_to_core; it can be { access_to_core, core_to_access, neither }. a single bool is not sufficient, an enum would do. a bool (two bools) is simplest to use in 'if' conditions File src/osmo-upf/up_session.c: https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/50e0494d_66d2f3d4 PS1, Line 1140: static void add_gtp_action_tunend(void *ctx, struct llist_head *dst, struct pdr *pdr) (s.b.) https://gerrit.osmocom.org/c/osmo-upf/+/30465/comment/dced0d69_0d8cb932 PS1, Line 1235: static void add_gtp_action_tunmap(void *ctx, struct llist_head *dst, struct pdr *pdr) the caller isn't interested in any result. since it is a static funtion no need to return anything before there is a direct need for that in the caller -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30465 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ia199bb6944476eff6af89b5ab015a9a2f8ce330e Gerrit-Change-Number: 30465 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Dec 2022 21:49:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment