Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/upf/up_session.h:

  • Patch Set #1, Line 97: bool access_to_core;

    Isn't access_to_core and core_to_access exclusive? meaning it's one or another and hence can be stor […]

    it can be { access_to_core, core_to_access, neither }. a single bool is not sufficient, an enum would do. a bool (two bools) is simplest to use in 'if' conditions

• File src/osmo-upf/up_session.c:

  • Patch Set #1, Line 1140: static void add_gtp_action_tunend(void *ctx, struct llist_head *dst, struct pdr *pdr)

    Looks like this function should return an int?

    (s.b.)

  • Patch Set #1, Line 1235: static void add_gtp_action_tunmap(void *ctx, struct llist_head *dst, struct pdr *pdr)

    Same, looks like this function should return an int?

    the caller isn't interested in any result. since it is a static funtion no need to return anything before there is a direct need for that in the caller

To view, visit change 30465. To unsubscribe, or for help writing mail filters, visit settings.