Attention is currently required from: neels, laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted
......................................................................
Patch Set 2:
(1 comment)
File src/sbcap/sbcap_common.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/e4e604b0_5c585749
PS2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));
If that ever happened, "(null)" would be printed which is not a big issue.
as discussed in chat, this is undefined behavior and it would be better to not rely on it.
see also: https://www.geeksforgeeks.org/g-fact-44-passing-null-to-printf-in-c/
otherwise the patch looks good to me!
--
To view, visit
https://gerrit.osmocom.org/c/osmo-cbc/+/28819
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04
Gerrit-Change-Number: 28819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: neels
nhofmeyr@sysmocom.de
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
osmith