Attention is currently required from: neels, laforge, pespin.

View Change

1 comment:

• File src/sbcap/sbcap_common.c:

  • Patch Set #2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));

    If that ever happened, "(null)" would be printed which is not a big issue.

    as discussed in chat, this is undefined behavior and it would be better to not rely on it.

    see also: https://www.geeksforgeeks.org/g-fact-44-passing-null-to-printf-in-c/

    otherwise the patch looks good to me!

To view, visit change 28819. To unsubscribe, or for help writing mail filters, visit settings.