Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 )

Change subject: trxcon: rework L1CTL socket API to support multiple clients ......................................................................

Patch Set 4:

(3 comments)

File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/337bb71c_2a4b761a PS4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */

Did you think about adding an . […]

Done

https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/1ec84f95_5b44ccda PS4, Line 35: struct llist_head list;

document where is this item added to. […]

Done

File src/host/trxcon/src/l1ctl_link.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/5c72b659_ed813453 PS4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags)

this new function name is misleading imho. […]

To me it reads as "accept client connection". l1ctl_server_conn_accept() also looks good to me... Ok, I'll change to l1ctl_server_conn_cb(). It's a callback after all.