Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 ) Change subject: trxcon: rework L1CTL socket API to support multiple clients ...................................................................... Patch Set 4: (3 comments) File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h: https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/337bb71c_2a4b761a PS4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */ Done https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/1ec84f95_5b44ccda PS4, Line 35: struct llist_head list; Done File src/host/trxcon/src/l1ctl_link.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/5c72b659_ed813453 PS4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags) To me it reads as "accept client connection". l1ctl_server_conn_accept() also looks good to me... Ok, I'll change to l1ctl_server_conn_cb(). It's a callback after all. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1cfc49f36ead6e2ba0a6110b0fb65c55412ef5e3 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jul 2022 18:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment