Attention is currently required from: pespin.

View Change

3 comments:

• File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h:

  • Patch Set #4, Line 29: l1ctl_conn_data_func *conn_read_cb; /* mandatory */

    Did you think about adding an . […]

    Done

  • Patch Set #4, Line 35: struct llist_head list;

    document where is this item added to. […]

    Done

• File src/host/trxcon/src/l1ctl_link.c:

  • Patch Set #4, Line 110: static int l1ctl_client_conn_accept(struct osmo_fd *sfd, unsigned int flags)

    this new function name is misleading imho. […]

    To me it reads as "accept client connection".
    l1ctl_server_conn_accept() also looks good to me...
    Ok, I'll change to l1ctl_server_conn_cb(). It's a callback after all.

To view, visit change 28669. To unsubscribe, or for help writing mail filters, visit settings.