Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35914?usp=email )
Change subject: gsm: add TCH block/lchan definitions for CSD ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/gsm/gsm44021.c:
https://gerrit.osmocom.org/c/libosmocore/+/35914/comment/efd82da4_dec8f4d7 PS2, Line 30: if 0 : [GSM48_CMODE_DATA_14k5] = { : /* TCH/F14.4: 290 bits every 20 ms (14.5 kbit/s) */ : .fr = { .num_frames = 1, .num_bits = 290 }, : }, : #endif i'm not quite sure I like that kind of commented-out data structure in libosmocore. After all, this data structure is describing bits from the specification, and whether or not other parts of libosmocore may or may not implement TCH/F14.4, the definitions stated here are still true, right?
-
laforge